Skip to content

smoke tests / CI : Fix test_vm_stric_host_tags#10806

Merged
weizhouapache merged 1 commit into4.20from
fix-strict-host-tags-test
May 4, 2025
Merged

smoke tests / CI : Fix test_vm_stric_host_tags#10806
weizhouapache merged 1 commit into4.20from
fix-strict-host-tags-test

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented May 2, 2025

Description

Fixes: #10802
This PR fixes the test failure observed with test_vm_strict_host_tags.py both in smoke test runs and CI
#10668 (comment)

https://github.com/apache/cloudstack/actions/runs/14738890400/job/41371735755?pr=10668
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg -s -a tags=advanced --hypervisor=simulator test/integration/smoke/test_vm_strict_host_tags.py

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /tmp/MarvinLogs/May_02_2025_15_57_28_F9LIM7 All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====
=== TestName: test_01_migrate_vm_strict_tags_success | Status : SUCCESS ===

=== TestName: test_02_migrate_vm_strict_tags_failure | Status : SUCCESS ===

=== TestName: test_01_restore_vm_strict_tags_success | Status : SUCCESS ===

=== TestName: test_02_restore_vm_strict_tags_failure | Status : SUCCESS ===

=== TestName: test_01_scale_vm_strict_tags_success | Status : SUCCESS ===

=== TestName: test_02_scale_vm_strict_tags_failure | Status : SUCCESS ===

=== TestName: test_01_deploy_vm_on_specific_host_without_strict_tags | Status : SUCCESS ===

=== TestName: test_02_deploy_vm_on_any_host_without_strict_tags | Status : SUCCESS ===

=== TestName: test_03_deploy_vm_on_specific_host_with_strict_tags_success | Status : SUCCESS ===

=== TestName: test_04_deploy_vm_on_any_host_with_strict_tags_success | Status : SUCCESS ===

=== TestName: test_05_deploy_vm_on_specific_host_with_strict_tags_failure | Status : SUCCESS ===

=== TestName: test_06_deploy_vm_on_any_host_with_strict_tags_failure | Status : SUCCESS ===

=== Final results are now copied to: /tmp/MarvinLogs/test_vm_strict_host_tags_00WIUK ===

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels May 2, 2025
@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 May 2, 2025
@Pearl1594 Pearl1594 added this to the 4.20.1 milestone May 2, 2025
@codecov
Copy link

codecov bot commented May 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.13%. Comparing base (91c1168) to head (fa86325).
Report is 1 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10806   +/-   ##
=========================================
  Coverage     16.13%   16.13%           
- Complexity    13217    13220    +3     
=========================================
  Files          5649     5649           
  Lines        496703   496703           
  Branches      60179    60179           
=========================================
+ Hits          80129    80148   +19     
+ Misses       407656   407633   -23     
- Partials       8918     8922    +4
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented May 2, 2025

@blueorangutan package

DaanHoogland
DaanHoogland approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

DaanHoogland commented May 2, 2025

oh wait, wasn’t it an issue on 4.19 as well?

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented May 2, 2025

I didn't see this failure on 4.19 health check @DaanHoogland

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DaanHoogland
Copy link
Contributor

DaanHoogland commented May 2, 2025

I didn't see this failure on 4.19 health check @DaanHoogland

sorry @Pearl1594 , it was the test_outofbandmanagement that fails on 4.19 in the GHA

weizhouapache
weizhouapache approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

just curious which PR caused the issue

@Pearl1594
Copy link
Contributor Author

Pearl1594 commented May 2, 2025

code lgtm

just curious which PR caused the issue

I believe it was this: #10603 - however I am not sure how it works on 4.19, because, this fix originally went in in 4.19

@weizhouapache
Copy link
Member

weizhouapache commented May 2, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented May 2, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented May 2, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13245

@weizhouapache
Copy link
Member

weizhouapache commented May 3, 2025

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented May 3, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented May 4, 2025

[SF] Trillian test result (tid-13198)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57627 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10806-t13198-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache merged commit 83c3ea2 into 4.20 May 4, 2025
37 of 49 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 May 4, 2025
@DaanHoogland DaanHoogland deleted the fix-strict-host-tags-test branch May 5, 2025 07:54
@DaanHoogland DaanHoogland mentioned this pull request May 7, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@Pearl1594 @dhslove
smoke tests / CI : Fix test_vm_stric_host_tags (apache#10806)
03aed8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Pearl1594 @DaanHoogland @weizhouapache @blueorangutan